Moving FSL into riscv-perf-model #263
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arupc
approved these changes
Jul 7, 2025
|
During our meeting on July 7th, 2025, @rajatbhatia1 had a good idea to investigate forking submodules like @arupc will investigate how we can do this, and if we can make that happen, I'll close this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The software package "Fusion/Fracture Specification Language" written by Jeff Nye (@jeffnye-gh) was
provided to the RISC-V Performance Modeling SIG under the Apache License 2.0 agreement
as a submodule (
fsl) to riscv-perf-model GitHub repo.Having such a dependency exposes unintended consequences where the original author can, at any juncture, remove access to that submodule thus inhibiting, if not halting, development within this SIG.
In addition, updates/changes to this dependency must go through the original author thus potentially delaying
progress of riscv-perf-model development.
This PR copies the
fslsubmodule directly into the riscv-perf-model GitHub repository and removes the externaldependency. Specifically, section 4 of the Apache 2.0 License agreement, provided in the original FSL distribution states:
In addition, to adhere to section 4b:
The FSL library was copied as is without modification and therefore does not contain any additional
prominent notices.